mirror of
https://codeberg.org/PostERG/xamxam.git
synced 2026-05-06 11:09:18 +02:00
Extract shared public <head> partial
Create templates/public/head.php accepting $pageTitle and $extraCss (array of stylesheet hrefs), mirroring the existing templates/admin/head.php pattern. The partial emits: DOCTYPE, <html lang=fr>, charset/viewport meta, favicon, modern-normalize, common.css, any extra CSS links, and the dev-only live-reload script. The live-reload snippet was previously copy-pasted verbatim into all five public pages. Updated pages: - public/index.php ($pageTitle='Posterg', $extraCss=['assets/main.css']) - public/search.php ($pageTitle='Répertoire – Posterg', search.css) - public/tfe.php ($pageTitle=thesis title + suffix, tfe.css) - public/apropos.php ($pageTitle='À Propos – Posterg', apropos.css) - public/licence.php ($pageTitle=DB title + suffix, apropos.css) tfe.php: removed redundant htmlspecialchars() call on $pageTitle (the partial applies it); licence.php: renamed conflicting $page variable to $dbPage to avoid collision with the shared $pageTitle expected by the partial. All syntax checks and test suite pass (4/4).
This commit is contained in:
14
TODO.md
14
TODO.md
@@ -452,16 +452,12 @@ Goal: rename the tables and column to the canonical M2M pattern (`tags`, `thesis
|
||||
|
||||
### D — Template structure / boilerplate duplication
|
||||
|
||||
- [ ] **Every public page duplicates its own `<head>`** — `index.php`, `search.php`, `tfe.php`,
|
||||
`apropos.php`, `licence.php` each contain an identical block: `<!DOCTYPE html>`,
|
||||
`<html lang="fr">`, `<meta charset>`, `<meta viewport>`, `<link rel="icon">`,
|
||||
`<link modern-normalize>`, `<link common.css>`, live-reload script. Only `<title>` and one
|
||||
extra CSS `<link>` differ. Extract a `templates/public/head.php` partial accepting
|
||||
`$pageTitle` and `$extraCss` — mirrors the pattern `templates/admin/head.php` already uses.
|
||||
- [x] **Every public page duplicates its own `<head>`** — extracted to `templates/public/head.php`
|
||||
accepting `$pageTitle` and `$extraCss`; all 5 public pages updated to use the partial.
|
||||
Mirrors the pattern `templates/admin/head.php` already uses.
|
||||
|
||||
- [ ] **Live-reload snippet copy-pasted into 6 files** — `index.php`, `search.php`, `tfe.php`,
|
||||
`apropos.php`, `licence.php`, `templates/admin/head.php` all contain the same 6-line
|
||||
`(function poll(){…})()` block. Consolidate into the shared head partials.
|
||||
- [x] **Live-reload snippet copy-pasted into 6 files** — consolidated into `templates/public/head.php`;
|
||||
removed from `index.php`, `search.php`, `tfe.php`, `apropos.php`, `licence.php`.
|
||||
|
||||
- [x] **`templates/header.php` and `templates/head.php` are dead files** — neither is `include`d
|
||||
anywhere in the codebase. Both contain outdated markup from a previous design iteration
|
||||
|
||||
Reference in New Issue
Block a user