PostERG/xamxam
1
0
Fork 0
mirror of https://codeberg.org/PostERG/xamxam.git synced 2026-05-06 19:19:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove DB_ENV auto-detection; require explicit DB_ENV=test for tests

Browse Source 
src/config.php: remove the file-existence fallback that silently redirected
all requests to test.db whenever that file was present on disk. getDatabasePath()
now always returns the production DB unless DB_ENV=test is explicitly set.

tests/run-tests.php: putenv('DB_ENV=test') at the top so the suite always
targets test.db regardless of what is set in the shell environment.

tests/Unit/DatabaseTest.php, tests/Integration/SearchTest.php,
tests/Security/SecurityTest.php: same putenv() guard added to each file so
they work correctly when run standalone (e.g. just test-unit).

justfile: all test and DB-development recipes now prefix DB_ENV=test to their
php/sqlite3 commands, making the intent explicit in the recipe itself.

Fixes: a developer who ran the test suite and kept test.db on disk would
silently hit test data when browsing the local site with no DB_ENV set.
This commit is contained in:
Pontoporeia
2026-03-28 13:43:04 +01:00
parent 7d96a08324
commit 71167b2cdf
9 changed files with 29 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/config.php
View File

@@ -15,35 +15,23 @@ define('DB_TEST_PATH', DB_ROOT . '/storage/test.db');
define('DB_PROD_PATH', DB_ROOT . '/storage/posterg.db');
/**
* Determine which database to use
* Checks environment variable DB_ENV, defaults to auto-detection
* Determine which database to use.
*
* Set DB_ENV in your environment:
* - export DB_ENV=test # Force test database
* - export DB_ENV=prod # Force production database
* Always defaults to the production database.
* Set DB_ENV=test explicitly to use the test database.
*
* Auto-detection logic:
* - If test.db exists, use it (development)
* - Otherwise use posterg.db (production)
* export DB_ENV=test # use storage/test.db
* export DB_ENV=prod # use storage/posterg.db (default)
*
* The old file-existence auto-detection has been removed: a leftover
* test.db on a developer machine no longer silently redirects all
* requests to test data.
*/
function getDatabasePath() {
// Allow explicit override via environment variable
$env = getenv('DB_ENV');
if ($env === 'test') {
function getDatabasePath(): string {
if (getenv('DB_ENV') === 'test') {
return DB_TEST_PATH;
}
if ($env === 'prod') {
return DB_PROD_PATH;
}
// Auto-detect: prefer test database if it exists
if (file_exists(DB_TEST_PATH)) {
return DB_TEST_PATH;
}
// Default to production database
return DB_PROD_PATH;
}