fix: partials must not unset caller-owned $formData

fieldset-academic.php, fieldset-metadata.php and fieldset-licence-explanation.php
were each calling unset($formData) (or wrong variable) in their cleanup block,
destroying the variable in the parent renderShareLinkForm() scope.  This caused
an Undefined variable / TypeError on old($formData, ...) for any field rendered
after those partials (e.g. confirmation_email at line 328).

Fix: remove $formData from the unset() calls; fieldset-licence-explanation.php
was also unsetting the wrong name — corrected to unset($n) which is the variable
it actually declares.

TODO.md

@@ -12,6 +12,8 @@
 ## Bug fixes
 
 - [x] Fix `$enabledAccessTypes` undefined / `array_map()` TypeError on edit page — controller was fetching `getAccessTypes()` instead of `getEnabledFormAccessTypes()` and returning it under the wrong key
+- [x] Fix fatal TypeError: `old()` called with wrong arity in `jury-fieldset.php` partial under partage context — removed `?: null` coercions so `$juryPresident`/`$juryPromoteur` are `''` not `null`, keeping `$addMode` false
+- [x] Fix `$formData` destroyed by included partials (`fieldset-academic.php`, `fieldset-metadata.php`, `fieldset-licence-explanation.php` were incorrectly unsetting `$formData`/wrong variable in caller scope)
 
 ## Form help blocks — sortable admin UI
 

app/templates/partials/form/fieldset-academic.php

@@ -59,4 +59,4 @@ $formData        = $formData        ?? [];
     ?>
 </fieldset>
 <?php
-unset($oldFn, $withAutofocusFn, $formData);
+unset($oldFn, $withAutofocusFn);

app/templates/partials/form/fieldset-licence-explanation.php

@@ -58,4 +58,4 @@ $formData = $formData ?? [];
     </div>
 </fieldset>
 <?php
-unset($formData);
+unset($n);

app/templates/partials/form/fieldset-metadata.php

@@ -60,4 +60,4 @@ $selectedAccessType = isset($formData['access_type_id'])
     ?>
 </fieldset>
 <?php
-unset($oldFn, $withAutofocusFn, $formData, $defaultAccessTypeId, $showDescription, $accessOptions, $selectedAccessType);
+unset($oldFn, $withAutofocusFn, $defaultAccessTypeId, $showDescription, $accessOptions, $selectedAccessType);