From 8545daaccc6cde7b2365f11e0429147335f68977 Mon Sep 17 00:00:00 2001
From: Pontoporeia <pontoporeia@happyngreen.fr>
Date: Sun, 10 May 2026 22:18:15 +0200
Subject: [PATCH] fix migration 028, promoteurice repopulation, DB bootstrap

- Fix undefined $isExternalUrl in tfe.php (moved after assignment)
- Disable PeerTube rendering in tfe.php entirely
- Migration 028: drop banner_path from theses with proper view handling
  - Drop dependent views before column, recreate without banner_path
  - Remove broken 027_drop_banner_path.sql
  - Move 025_fix_oui_non_artefacts.sql and 021_peertube_settings.sql to applied/
- Add scripts/ensure-db.php to init fresh DB from schema.sql when missing
- Update deploy justfile to run ensure-db.php before migrations
- Fix promoteurice array repopulation in partage form:
  - Fix old() to return raw arrays (not json_encode) so callers can iterate
  - Handle jury_promoteur[] and jury_promoteur_ulb_name[] arrays properly
---
 app/templates/admin/acces.php                 | 13 +++++++++++++
 app/templates/partials/form/jury-fieldset.php |  4 ++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/app/templates/admin/acces.php b/app/templates/admin/acces.php
index d792602..e249e09 100644
--- a/app/templates/admin/acces.php
+++ b/app/templates/admin/acces.php
@@ -467,6 +467,19 @@
 +%%%%%%% diff from: somsyvxz 249f7943 "Bulk bar anti-shift, tags icons, AP no-wrap, credits reorder" (rebased revision)
 +\\\\\\\        to: xznsyswm a408afdc "FilePond production hardening" (rebased revision)
 ++                        $linkName = $link['name'] ?? '';
+++                        $linkExpiresVal = $link['expires_at'] ? date('Y-m-d\TH:i', strtotime($link['expires_at'])) : '';
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% diff from: xznsyswm a408afdc "FilePond production hardening" (rebased revision)
+\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\        to: somsyvxz 249f7943 "Bulk bar anti-shift, tags icons, AP no-wrap, credits reorder" (rebased revision)
+-                        $linkName = $link['name'] ?? '';
+-                        $linkExpiresVal = $link['expires_at'] ? date('Y-m-d\TH:i', strtotime($link['expires_at'])) : '';
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% diff from: somsyvxz 14a3cd10 "Bulk bar anti-shift, tags icons, AP no-wrap, credits reorder" (rebase destination)
+\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\        to: vqxpnkox 1fba7167 "fix migration 028, promoteurice repopulation, DB bootstrap" (rebased revision)
+                         $linkName = $link['name'] ?? '';
+                         $linkExpiresVal = $link['expires_at'] ? date('Y-m-d\TH:i', strtotime($link['expires_at'])) : '';
+                         $linkLockedYear = $link['locked_year'] ?? null;
++%%%%%%% diff from: somsyvxz 249f7943 "Bulk bar anti-shift, tags icons, AP no-wrap, credits reorder" (rebased revision)
++\\\\\\\        to: vqxpnkox f51d447c "fix migration 028, promoteurice repopulation, DB bootstrap" (rebased revision)
+++                        $linkName = $link['name'] ?? '';
 ++                        $linkExpiresVal = $link['expires_at'] ? date('Y-m-d\TH:i', strtotime($link['expires_at'])) : '';
                     ?>
                     <tr class="admin-table-row" onclick="event.stopPropagation(); window.open('/partage/<?= urlencode($link['slug']) ?>', '_blank')" style="cursor:pointer">
diff --git a/app/templates/partials/form/jury-fieldset.php b/app/templates/partials/form/jury-fieldset.php
index 6ae79fe..0daf990 100644
--- a/app/templates/partials/form/jury-fieldset.php
+++ b/app/templates/partials/form/jury-fieldset.php
@@ -95,7 +95,7 @@ if ($addMode && function_exists('old')) {
             <?php endif; ?>
         </div>
         <button type="button" class="btn btn--secondary admin-add-jury-btn"
-                onclick="addJuryRow('jury-promoteur-interne-list', 'jury_promoteur', 'Promoteur·ice interne')">
+                onclick="addJuryRow('jury-promoteur-interne-list', 'jury_promoteur[]', 'Promoteur·ice interne')">
             + Ajouter un·e promoteur·ice interne
         </button>
     </fieldset>
@@ -133,7 +133,7 @@ if ($addMode && function_exists('old')) {
             <?php endif; ?>
         </div>
         <button type="button" class="btn btn--secondary admin-add-jury-btn"
-                onclick="addJuryRow('jury-promoteur-ulb-list', 'jury_promoteur_ulb_name', 'Promoteur·ice ULB')">
+                onclick="addJuryRow('jury-promoteur-ulb-list', 'jury_promoteur_ulb_name[]', 'Promoteur·ice ULB')">
             + Ajouter un·e promoteur·ice ULB
         </button>
     </fieldset>