fix: iframe for PDF display, exclude cover files from public loop, no session on media requests

This commit is contained in:
Pontoporeia
2026-04-27 21:11:58 +02:00
parent 46a3c360ec
commit e09b056115
3 changed files with 18 additions and 6 deletions

View File

@@ -1,5 +1,11 @@
# TODO
## TFE Public Page — File Display
- [x] Replace `<embed>` with `<iframe>` for PDF display (better cross-browser support)
- [x] Exclude `cover` file_type from public files loop (covers are banners, not content)
- [x] Move `App::boot()` in Dispatcher to after direct-response matching (no session on media requests)
## Dev / Debug Fixes
- [x] Fix `serve` recipe: show all PHP output (errors, logs) except static assets/connection noise

View File

@@ -48,9 +48,6 @@ class Dispatcher {
* execute the action, and render the view.
*/
public function dispatch(): void {
// Ensure session + CSRF token are initialised for all public requests
require_once APP_ROOT . '/src/App.php';
App::boot();
// 1. Direct-response endpoints (render their own output)
$direct = $this->matchDirect();
if ($direct) {
@@ -58,6 +55,10 @@ class Dispatcher {
return;
}
// Ensure session + CSRF token are initialised for routed pages
require_once APP_ROOT . '/src/App.php';
App::boot();
// 2. Routed pages (controller + view)
$route = $this->matchRoute();
if (!$route) {

View File

@@ -290,13 +290,18 @@
<?php elseif (!empty($data['files'])): ?>
<?php foreach ($data['files'] as $file): ?>
<?php
$ext = strtolower(pathinfo($file['file_path'], PATHINFO_EXTENSION));
$ext = strtolower(pathinfo($file['file_path'], PATHINFO_EXTENSION));
$fileType = $file['file_type'] ?? '';
if ($ext === 'vtt') continue;
if ($fileType === 'cover') continue;
?>
<figure>
<?php if ($ext === 'pdf'): ?>
<embed src="/media?path=<?= urlencode($file['file_path']) ?>"
type="application/pdf" width="100%" height="700px">
<iframe src="/media?path=<?= urlencode($file['file_path']) ?>"
width="100%" height="700px"
style="border:none"
title="<?= htmlspecialchars($file['original_name'] ?? basename($file['file_path'])) ?>">
</iframe>
<p class="tfe-pdf-fallback">
<a href="/media?path=<?= urlencode($file['file_path']) ?>&download=1">
Télécharger le PDF