PostERG/xamxam
1
0
Fork 0
mirror of https://codeberg.org/PostERG/xamxam.git synced 2026-05-06 11:09:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Replace .admin-alert BEM classes with semantic role/data-type attributes

Browse Source 
- admin.css: replace .admin-alert / .admin-alert--error / .admin-alert--success
  selectors with [role="alert"][data-type="error"] and [role="status"][data-type="success"]
- All 10 admin templates updated: <div class="admin-alert admin-alert--{type}">
  becomes <p role="alert|status" data-type="error|success"> (or <div> for the
  import.php multi-item list that contains a <ul>)
- flash-messages.php partial updated to match
- WCAG benefit: role="alert" is an ARIA live region — errors are announced
  immediately by screen readers without focus movement (fixes WCAG 3.3.1, 4.1.2)
- role="status" (polite live region) used for success messages — announced
  without interrupting the user
- Removes two BEM modifier classes; CSS now targets element semantics directly
This commit is contained in:
Pontoporeia
2026-04-02 12:35:23 +02:00
parent 10b07393fe
commit e9e012376d
12 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
TODO.md
View File

@@ -5,7 +5,7 @@
### CSS class audit: replace with semantic selectors ### CSS class audit: replace with semantic selectors
- [x] **`admin.css`**: Replace `.admin-main` with `.admin-body main` — only one `<main>` per page - [x] **`admin.css`**: Replace `.admin-main` with `.admin-body main` — only one `<main>` per page
- [x] **`admin.css`**: Replace `.admin-page-title` with `.admin-body main > h1` — always the first `h1` in `<main>` - [x] **`admin.css`**: Replace `.admin-page-title` with `.admin-body main > h1` — always the first `h1` in `<main>`
- [ ] **`admin.css`**: Replace `.admin-alert` / `.admin-alert--error` / `.admin-alert--success` with `[role="alert"]` or `.admin-body main > .alert` using `data-type="error|success"` attribute instead of modifier classes - [x] **`admin.css`**: Replace `.admin-alert` / `.admin-alert--error` / `.admin-alert--success` with `[role="alert"]` or `.admin-body main > .alert` using `data-type="error|success"` attribute instead of modifier classes
- [ ] **`admin.css`**: Replace `.admin-form-row` with `.admin-body form > div` or `.admin-body form > .row` — form rows are always direct `<div>` children of `<form>` - [ ] **`admin.css`**: Replace `.admin-form-row` with `.admin-body form > div` or `.admin-body form > .row` — form rows are always direct `<div>` children of `<form>`
- [ ] **`admin.css`**: Replace `.admin-label` with `.admin-body form label` — every label in admin forms - [ ] **`admin.css`**: Replace `.admin-label` with `.admin-body form label` — every label in admin forms
- [ ] **`admin.css`**: Replace `.admin-input` / `.admin-select` / `.admin-textarea` with `.admin-body form input[type="text"]`, `.admin-body form select`, `.admin-body form textarea` — leverage native element selectors - [ ] **`admin.css`**: Replace `.admin-input` / `.admin-select` / `.admin-textarea` with `.admin-body form input[type="text"]`, `.admin-body form select`, `.admin-body form textarea` — leverage native element selectors

4
public/admin/account.php
View File

@@ -23,10 +23,10 @@ if (empty($_SESSION['csrf_token'])) {
<h1>Compte administrateur</h1> <h1>Compte administrateur</h1>
<?php if ($error): ?> <?php if ($error): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($error) ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($error) ?></p>
<?php endif; ?> <?php endif; ?>
<?php if ($success): ?> <?php if ($success): ?>
<div class="admin-alert admin-alert--success">✓ <?= htmlspecialchars($success) ?></div> <p role="status" data-type="success">✓ <?= htmlspecialchars($success) ?></p>
<?php endif; ?> <?php endif; ?>
<!-- Status info --> <!-- Status info -->

2
public/admin/add.php
View File

@@ -46,7 +46,7 @@ function wasSelected($key, $value) {
<h1>Ajouter un TFE</h1> <h1>Ajouter un TFE</h1>
<?php if ($error): ?> <?php if ($error): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($error) ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($error) ?></p>
<?php endif; ?> <?php endif; ?>
<form action="actions/formulaire.php" method="post" enctype="multipart/form-data" class="admin-form"> <form action="actions/formulaire.php" method="post" enctype="multipart/form-data" class="admin-form">

4
public/admin/edit.php
View File

@@ -68,10 +68,10 @@ try {
<h1>Modifier un TFE</h1> <h1>Modifier un TFE</h1>
<?php if ($error): ?> <?php if ($error): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($error) ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($error) ?></p>
<?php endif; ?> <?php endif; ?>
<?php if ($success): ?> <?php if ($success): ?>
<div class="admin-alert admin-alert--success">✓ <?= htmlspecialchars($success) ?></div> <p role="status" data-type="success">✓ <?= htmlspecialchars($success) ?></p>
<?php endif; ?> <?php endif; ?>
<form method="post" action="/admin/actions/edit.php" class="admin-form" enctype="multipart/form-data"> <form method="post" action="/admin/actions/edit.php" class="admin-form" enctype="multipart/form-data">

4
public/admin/import.php
View File

@@ -324,7 +324,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST' && isset($_FILES['csv_file'])) {
<h1>Importer une liste de TFE</h1> <h1>Importer une liste de TFE</h1>
<?php if (!empty($errors)): ?> <?php if (!empty($errors)): ?>
<div class="admin-alert admin-alert--error"> <div role="alert" data-type="error">
<strong>⚠ Erreurs :</strong> <strong>⚠ Erreurs :</strong>
<ul style="margin:.5rem 0 0;padding-left:1.2rem;"> <ul style="margin:.5rem 0 0;padding-left:1.2rem;">
<?php foreach ($errors as $err): ?> <?php foreach ($errors as $err): ?>
@@ -335,7 +335,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST' && isset($_FILES['csv_file'])) {
<?php endif; ?> <?php endif; ?>
<?php if ($message): ?> <?php if ($message): ?>
<div class="admin-alert admin-alert--success">✓ <?= htmlspecialchars($message) ?></div> <p role="status" data-type="success">✓ <?= htmlspecialchars($message) ?></p>
<?php endif; ?> <?php endif; ?>
<form action="import.php" method="post" enctype="multipart/form-data" class="admin-import-area"> <form action="import.php" method="post" enctype="multipart/form-data" class="admin-import-area">

4
public/admin/index.php
View File

@@ -68,10 +68,10 @@ document.addEventListener('DOMContentLoaded', () => {
<h1>Liste des TFE</h1> <h1>Liste des TFE</h1>
<?php if (isset($_SESSION['error'])): ?> <?php if (isset($_SESSION['error'])): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($_SESSION['error']); unset($_SESSION['error']); ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($_SESSION['error']); unset($_SESSION['error']); ?></p>
<?php endif; ?> <?php endif; ?>
<?php if (isset($_SESSION['success'])): ?> <?php if (isset($_SESSION['success'])): ?>
<div class="admin-alert admin-alert--success">✓ <?= htmlspecialchars($_SESSION['success']); unset($_SESSION['success']); ?></div> <p role="status" data-type="success">✓ <?= htmlspecialchars($_SESSION['success']); unset($_SESSION['success']); ?></p>
<?php endif; ?> <?php endif; ?>
<!-- Maintenance mode toggle --> <!-- Maintenance mode toggle -->

2
public/admin/login.php
View File

@@ -30,7 +30,7 @@ $pageTitle = 'Connexion';
<div class="admin-login-box"> <div class="admin-login-box">
<h2>Administration</h2> <h2>Administration</h2>
<?php if ($error): ?> <?php if ($error): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($error) ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($error) ?></p>
<?php endif; ?> <?php endif; ?>
<form method="post" action="/admin/login.php" class="admin-form"> <form method="post" action="/admin/login.php" class="admin-form">
<div class="admin-form-row"> <div class="admin-form-row">

2
public/admin/pages.php
View File

@@ -25,7 +25,7 @@ unset($_SESSION['success']);
<h1>Pages statiques</h1> <h1>Pages statiques</h1>
<?php if ($success): ?> <?php if ($success): ?>
<div class="admin-alert admin-alert--success">✓ <?= htmlspecialchars($success) ?></div> <p role="status" data-type="success">✓ <?= htmlspecialchars($success) ?></p>
<?php endif; ?> <?php endif; ?>
<table> <table>

4
public/admin/tags.php
View File

@@ -29,10 +29,10 @@ unset($_SESSION['admin_error'], $_SESSION['admin_success']);
<h1>Mots-clés (<?= count($tags) ?>)</h1> <h1>Mots-clés (<?= count($tags) ?>)</h1>
<?php if ($error): ?> <?php if ($error): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($error) ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($error) ?></p>
<?php endif; ?> <?php endif; ?>
<?php if ($success): ?> <?php if ($success): ?>
<div class="admin-alert admin-alert--success">✓ <?= htmlspecialchars($success) ?></div> <p role="status" data-type="success">✓ <?= htmlspecialchars($success) ?></p>
<?php endif; ?> <?php endif; ?>
<table> <table>

2
public/admin/thanks.php
View File

@@ -69,7 +69,7 @@ $pageTitle = "Récapitulatif TFE";
<h1>Récapitulatif TFE</h1> <h1>Récapitulatif TFE</h1>
<?php if ($error): ?> <?php if ($error): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($error) ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($error) ?></p>
<p><a href="/admin/add.php" class="admin-btn-secondary">Retour au formulaire</a></p> <p><a href="/admin/add.php" class="admin-btn-secondary">Retour au formulaire</a></p>
<?php elseif ($thesis): ?> <?php elseif ($thesis): ?>

7
public/assets/css/admin.css
View File

@@ -276,7 +276,8 @@
} }
/* ---- Alert Messages ---- */ /* ---- Alert Messages ---- */
.admin-alert { [role="alert"],
[role="status"] {
padding: 0.75rem 1rem; padding: 0.75rem 1rem;
border-radius: 3px; border-radius: 3px;
font-size: 0.9rem; font-size: 0.9rem;
@@ -284,13 +285,13 @@
border-left: 3px solid; border-left: 3px solid;
} }
.admin-alert--error { [role="alert"][data-type="error"] {
background: rgba(200, 0, 0, 0.1); background: rgba(200, 0, 0, 0.1);
border-color: #c00; border-color: #c00;
color: #ff6b6b; color: #ff6b6b;
} }
.admin-alert--success { [role="status"][data-type="success"] {
background: rgba(0, 150, 80, 0.1); background: rgba(0, 150, 80, 0.1);
border-color: #0a0; border-color: #0a0;
color: #4caf50; color: #4caf50;

4
templates/partials/flash-messages.php
View File

@@ -11,8 +11,8 @@
$_flash = App::consumeFlash(); $_flash = App::consumeFlash();
?> ?>
<?php if ($_flash['error']): ?> <?php if ($_flash['error']): ?>
<div class="admin-alert admin-alert--error">⚠ <?= htmlspecialchars($_flash['error']) ?></div> <p role="alert" data-type="error">⚠ <?= htmlspecialchars($_flash['error']) ?></p>
<?php endif; ?> <?php endif; ?>
<?php if ($_flash['success']): ?> <?php if ($_flash['success']): ?>
<div class="admin-alert admin-alert--success">✓ <?= htmlspecialchars($_flash['success']) ?></div> <p role="status" data-type="success">✓ <?= htmlspecialchars($_flash['success']) ?></p>
<?php endif; ?> <?php endif; ?>