Files
xamxam/TODO.md
Pontoporeia cefceb046c feat: jury composition + banner image upload
- migration 004: thesis_supervisors.role + is_external; view adds jury_president/jury_promoteurs/jury_lecteurs
- migration 005: theses.banner_path; view exposes t.banner_path and t.license_id
- Database: getThesisJury(), setThesisJury(), setBannerPath()
- admin/add.php: jury fieldset (président/promoteur/lecteurs + externe checkboxes, JS add/remove rows); banner file input
- admin/edit.php: jury fieldset pre-populated from DB; banner preview + remove checkbox + upload; multipart form
- admin/actions/formulaire.php: parse jury fields → setThesisJury(); banner upload to banners/
- tfe.php: three conditional jury rows (président·e, promoteur·ice, lecteur·ices)
- schema.sql: updated thesis_supervisors, theses, v_theses_full, v_theses_public definitions
- admin.css: fieldset, jury-row, jury-entry, btn-remove styles
2026-03-24 13:25:23 +01:00

16 KiB

TODO

Styling Redesign (matching design images)

  • Redesign shared nav bar (purple gradient top, flat, POSTERG / RÉPERTOIRE / À PROPOS)
  • Redesign shared search bar (full-width, icon, bottom border only, white bg)
  • Rewrite common.css (nav + search bar components)
  • Rewrite main.css (home page — white bg, media card grid, label below)
  • Rewrite search.css (répertoire index — 4-col ANNÉES/CATÉGORIES/ÉTUDIANTES/MOTS-CLÉS)
  • Rewrite tfe.css (TFE page — 2-col, large author/title left, media right)
  • Add apropos.css (À Propos — 2-col, large monospace text)
  • Rewrite admin.css (dark bg, purple gradient nav, bottom-border-only form inputs)
  • Update templates/nav.php (new shared nav partial)
  • Update templates/search-bar.php (new shared search bar partial)
  • Rewrite public/index.php (home page with new layout)
  • Rewrite public/search.php (répertoire index view + search results view)
  • Rewrite public/tfe.php (individual TFE page)
  • Create public/apropos.php (À Propos page)
  • Rewrite templates/admin/head.php (admin nav)
  • Rewrite templates/admin/footer.php (clean close)
  • Rewrite public/admin/add.php (form with row layout)
  • Rewrite public/admin/index.php (dark table)
  • Rewrite public/admin/edit.php (form with row layout)
  • Rewrite public/admin/login.php (centered dark login box)
  • Rewrite public/admin/thanks.php (dark info cards)
  • Rewrite public/admin/import.php (clean dark form)

Justfile / Ops

  • Simplify serve and deploy to one recipe each
  • Remove sysadmin recipes (server-logs, server-status, deploy-nginx, deploy-admin-tools)
  • Extract server scripts to scripts/ (deploy-server.sh, manage-admin-users.sh)
  • Guard deploy-db against overwriting existing remote database
  • Update README.md and docs/SERVER_SETUP.md to reflect current structure

NEW FEATURES

1 — License page (public)

Create a public-facing /licence.php page, styled consistently with apropos.php.

  • public/licence.php — new public page; fetches content from pages table (slug 'licenses'); renders with Parsedown Markdown; uses apropos.css layout
  • templates/nav.php — add "Licence" link between "Répertoire" and "À Propos"; apply site-nav__link--active when $currentNav === 'licence'
  • The pages table row for slug 'licenses' verified in live DB

2 — Admin: WYSIWYG/Markdown editors for static pages

Allow admins to edit the content of the "À propos" and "Licence" pages from the admin panel, stored in the existing pages table.

2a — src/Database.php

  • getPage(string $slug): array|nullSELECT * FROM pages WHERE slug = ?
  • savePage(string $slug, string $content): void — throws if slug not found
  • getAllPages(): array — for listing in admin

2b — Admin pages editor UI

  • public/admin/pages.php — list all editable pages; links to edit each one
  • public/admin/pages-edit.php — EasyMDE WYSIWYG Markdown editor via CDN

2c — public/admin/actions/page.php

  • Auth guard + CSRF check + slug validation + length validation + savePage + redirect

2d — Public pages render Markdown

  • public/apropos.php — renders $db->getPage('about') via Parsedown (bundled src/Parsedown.php)
  • public/licence.php — renders $db->getPage('licenses') via Parsedown
  • Parsedown bundled as src/Parsedown.php (zero-dependency, MIT)
  • templates/admin/head.php — "Pages statiques" nav item added

3 — License field on TFE forms

Add a "Licence" dropdown to the Add and Edit TFE forms. The license_types table already exists in the schema with an id, name, description structure but has no seed data yet.

3a — Schema / DB

  • storage/schema.sql — seed INSERT OR IGNORE for 8 CC licence types added
  • storage/migrations/003_seed_license_types.sql — migration created + applied
  • Verified live DB has license_types with 8 rows

3b — src/Database.php

  • getLicenseTypes(): array
  • getAllLicenseTypes(): array — alias

3c — Add form (public/admin/add.php)

  • Loads $licenseTypes; "Licence" <select name="license_id"> added before duration

3d — Add action (public/admin/actions/formulaire.php)

  • $licenseId parsed + included in INSERT

3e — Edit form (public/admin/edit.php)

  • Loads $licenseTypes; raw license_id FK fetched directly; select pre-populated
  • POST handler: license_id included in UPDATE

3f — View update

  • storage/schema.sqlv_theses_full now exposes t.license_id raw FK (done as part of 004/005 view rebuild)

3g — TFE public page

  • public/tfe.php — "Licence :" meta row added, shown when non-null

4 — Jury composition section in Add/Edit forms

Replace the current flat "promoteur interne / externe" fields with a structured Composition du jury section: président·e, promoteur·ice, lecteur·ices (mixed internal/external).

4a — Schema / DB

Current state: supervisors table + thesis_supervisors junction with a bare supervisor_order integer. No role distinction.

  • storage/migrations/004_jury_roles.sql: - ALTER TABLE thesis_supervisors ADD COLUMN role TEXT NOT NULL DEFAULT 'promoteur' — role values: 'president', 'promoteur', 'lecteur' - ALTER TABLE thesis_supervisors ADD COLUMN is_external INTEGER NOT NULL DEFAULT 0 — 1 = external, 0 = internal (replaces the old "promoteur externe" free-text field) - No data loss: existing rows get role = 'promoteur', is_external = 0
  • storage/schema.sql — add the two new columns to thesis_supervisors definition; update v_theses_full to expose jury members grouped by role: - GROUP_CONCAT(DISTINCT CASE WHEN ts.role='president' THEN s.name END) as jury_president - GROUP_CONCAT(DISTINCT CASE WHEN ts.role='promoteur' THEN s.name END) as jury_promoteurs - GROUP_CONCAT(DISTINCT CASE WHEN ts.role='lecteur' THEN s.name END) as jury_lecteurs - Keep the existing supervisors column (all names) for backwards compat - Migration SQL must DROP + CREATE the view

4b — src/Database.php

  • getThesisJury(int $thesisId): array — fetch all supervisors for a thesis with their role and is_external flag
  • setThesisJury(int $thesisId, array $juryMembers): void — delete + re-insert

4c — Add form (public/admin/add.php)

  • Remove promoteurice and promoteurice_externe fields
  • Add "Composition du jury" fieldset: président·e, promoteur·ice + externe checkbox, dynamic lecteur·ices list with JS add/remove

4d — Add action (public/admin/actions/formulaire.php)

  • Removed old promoteurice parsing; parse jury fields; call $db->setThesisJury()

4e — Edit form (public/admin/edit.php)

  • Load $jury = $db->getThesisJury($thesisId); jury fieldset pre-populated from DB
  • POST handler calls $db->setThesisJury()

4f — TFE public page (public/tfe.php)

  • Three conditional jury rows: Président·e, Promoteur·ice, Lecteur·ices

5 — Banner image upload for home page cards

Each TFE can have an optional banner image used as its home page card thumbnail. This is distinct from the existing "couverture" file concept (which goes into thesis_files as type 'cover') — the banner is specifically optimised for the home grid (wider, shorter aspect ratio).

5a — Schema / DB

  • storage/migrations/005_add_banner.sqlALTER TABLE theses ADD COLUMN banner_path TEXT
  • storage/schema.sqlbanner_path TEXT in theses; t.banner_path in view

5b — Add form (public/admin/add.php)

  • "Image bannière" file input added after couverture row

5c — Add action (public/admin/actions/formulaire.php)

  • Banner upload: MIME check, 5 MB cap, save to banners/, call setBannerPath()

5d — Edit form (public/admin/edit.php)

  • Banner preview img shown; remove_banner checkbox; new banner upload input
  • POST handler: unlinks old file on remove; processes new upload via setBannerPath()

5e — src/Database.php

  • banner_path exposed via view — verified; getThesisById() / getPublishedTheses() pick it up automatically
  • setBannerPath(int $thesisId, ?string $path): void added

6 — Home page: gradient placeholder cards & random ordering

6a — Gradient placeholder for cards without a banner

  • public/index.php — gradient placeholder using HSL hue from thesis ID
  • public/assets/main.css.card__media--gradient, .card__gradient-author, .card__gradient-title styles added

6b — Banner image as card thumbnail

  • public/index.php — checks banner_path first, falls through to gradient

6c — Random ordering from the latest year

  • src/Database.phpgetLatestYearTheses(int $limit = 24) + getLatestPublishedYear()
  • public/index.php — default home view uses random latest-year selection; paginated view for ?year=X and ?page=N; info label shown

Refactor: M2M tags via tags + thesis_tags junction table

The current schema stores keywords in a keywords table joined via thesis_keywords. The field column is named keyword (not name), breaking the naming convention used by every other lookup table (orientations.name, format_types.name, etc.). More critically, buildSearchConditions and the view v_theses_full filter keywords through GROUP_CONCAT strings with LIKE, bypassing the junction table entirely.

Goal: rename the tables and column to the canonical M2M pattern (tags, thesis_tags, tags.name), add the missing index, and rewrite all tag queries to use a proper JOIN.

1 — Schema migration (storage/schema.sql + live DB)

  • Rename table keywordstags; rename column keywords.keywordtags.name
  • Rename junction table thesis_keywordsthesis_tags; rename FK column thesis_keywords.keyword_idthesis_tags.tag_id
  • Composite PK on thesis_tags(tag_id, thesis_id) (tag first — matches the lookup pattern WHERE t.name = ?)
  • Add index idx_tags_name ON tags(name) (supports exact-match lookup on insert/find)
  • Update idx_thesis_keywords_* index names → idx_thesis_tags_thesis, idx_thesis_tags_tag
  • Update view v_theses_full / v_theses_public: replace LEFT JOIN keywords k ON tk.keyword_id = k.id … GROUP_CONCAT(DISTINCT k.keyword) with LEFT JOIN tags t ON tt.tag_id = t.id … GROUP_CONCAT(DISTINCT t.name)
  • Write and test a SQLite migration script (storage/migrations/001_rename_keywords_to_tags.sql)

2 — src/Database.php

  • findOrCreateKeyword()findOrCreateTag(): query tags table, column name
  • getUsedKeywords()getUsedTags(): rewrite to use proper M2M JOIN instead of querying the view: sql SELECT DISTINCT t.* FROM tags t JOIN thesis_tags tt ON t.id = tt.tag_id JOIN theses th ON tt.thesis_id = th.id WHERE th.is_published = 1 ORDER BY t.name
  • buildSearchConditions: replace the keywords LIKE :keyword view-string hack with a subquery using the junction table: sql EXISTS ( SELECT 1 FROM thesis_tags tt JOIN tags t ON t.id = tt.tag_id WHERE tt.thesis_id = theses.id AND t.name LIKE :keyword ESCAPE '\' ) (search still runs on v_theses_public; the subquery references the base table)
  • validateSearchParams: rename key 'keyword''tag' (or keep alias for backwards-compat during transition)
  • Add backwards-compat alias findOrCreateKeywordfindOrCreateTag and getUsedKeywordsgetUsedTags (remove after all callers updated)

3 — Admin write paths

  • public/admin/actions/formulaire.php: replace findOrCreateKeyword + INSERT INTO thesis_keywords with findOrCreateTag + INSERT INTO thesis_tags
  • public/admin/edit.php: same replacement in keyword update block (DELETE FROM thesis_keywordsDELETE FROM thesis_tags, insert loop)

4 — Public read paths

  • public/search.php: rename $keywords$tags; update getUsedKeywords() call → getUsedTags(); rename GET param keywordtag (keep old param as alias)
  • public/tfe.php: $data['keywords']$data['tags'] (view column rename)
  • templates/search-bar.php (if applicable): update any hardcoded keyword param refs

5 — Admin tag management UI (/admin/tags.php)

The goal is a dedicated page for viewing, renaming, merging, and deleting tags, with full referential-integrity awareness (no orphan thesis_tags rows, no broken search results).

5a — src/Database.php — new tag-management methods

  • getAllTagsWithCount(): array — return all tags with a thesis_count column
  • renameTag(int $id, string $newName): void
  • mergeTag(int $sourceId, int $targetId): void
  • deleteTag(int $id): void

5b — public/admin/tags.php — list + inline-edit view

  • Auth guard, CSRF, table with rename/merge/delete per row

5c — public/admin/actions/tag.php — POST action handler

  • Route on $_POST['action']: rename, merge, delete

5d — Nav & routing

  • templates/admin/head.php: add nav link to /admin/tags.php

5e — Propagation safety checklist

  • Verify all search/display paths remain correct after tag ops

6 — Tests

  • tests/Unit/DatabaseTest.php: add test for findOrCreateTag round-trip
  • tests/Integration/SearchTest.php: add test for tag-filter search using the new subquery

6 — Fixtures / seed data

  • storage/fixtures/CreateTestDatabase.php: update to use tags / thesis_tags table names and findOrCreateTag()

Feature: Mode Maintenance

  • Storage flag file storage/maintenance.flag
  • Public gate in config/bootstrap.php
  • public/maintenance.php (503 page)
  • public/admin/actions/maintenance.php (POST handler)
  • Admin UI toggle in public/admin/index.php

Feature: TFE Visibility States (publique / interne / interdit)

  • DB migration 002_add_visibility.sql
  • src/Database.phpsetVisibility(), bulkSetVisibility()
  • public/media.php — visibility gate
  • public/tfe.php — conditional rendering
  • public/admin/edit.php — visibility select + context_note textarea
  • public/admin/index.php — three-state badge + bulk actions
  • public/admin/actions/publish.php or new visibility.php

Pending

  • Add flake.nix for Nix-based PHP dev environment
  • Add favicon (<link rel="icon"> → admin_favicon.svg) to all pages; nginx 204 for /favicon.ico
  • Add pagination to répertoire student index (currently capped at 100)
  • Thumbnail generation / cover image support for home grid cards

Admin / Server

  • Create scripts/setup-server.sh (one-time server setup: group, ownership, setgid 2775 on dirs)
  • Add just setup-server recipe (rsync + run setup-server.sh on remote)
  • Exclude .claude and .pi from rsync deploy
  • Update docs/SERVER_SETUP.md with correct permissions rationale and troubleshooting
  • Add server status view in admin panel (nginx + php-fpm health, site HTTP check)
  • Add server log viewer in admin panel (tail nginx error/access logs via SSH or log endpoint)
  • Add nginx config deploy flow to admin panel (upload scripts/deploy-server.sh, run remotely)
  • Add admin user management UI (wraps scripts/manage-admin-users.sh on server)