mirror of https://codeberg.org/PostERG/xamxam.git synced 2026-05-07 03:29:19 +02:00

Files

Pontoporeia d9f94eeb13 a11y(jury-fieldset): fix WCAG 3.3.2, 4.1.2, 2.1.1 + audit 1.4.4/1.4.12

3.3.2 Labels or instructions
- Replace bare <label>Lecteur·ices :</label> (no 'for', no associated control)
  with <fieldset class="admin-jury-lecteurs"><legend>Lecteur·ices</legend>
  giving AT a proper programmatic label for the entire lecteur group

4.1.2 Name, role, value — Externe checkboxes lacked group context
- Add aria-label="Promoteur·ice — externe" on the promoteur Externe checkbox
- Add aria-label="Lecteur·ice N — nom" on every lecteur name input
- Add aria-label="Lecteur·ice N — externe" on every lecteur Externe checkbox
- All three attributes added to both PHP-rendered rows and the addJuryRow() JS
  that builds new rows dynamically

2.1.1 Keyboard — remove buttons already had aria-label; verified and updated
  label text to "Supprimer le lecteur·ice N" (consistent with new numbering)

CSS (admin.css)
- Add .admin-body fieldset fieldset.admin-jury-lecteurs rule: removes
  border/padding/background from the nested fieldset so it reads as a
  sub-group inside the outer jury fieldset, not a double-bordered card

Audit (no code change)
- WCAG 1.4.4: all font-size values use rem — no px text sizing anywhere
- WCAG 1.4.12: only overflow:hidden on media containers and .sr-only utility;
  no essential text content is clipped by text-spacing overrides
- WCAG 4.1.2 bulk JS: result is a redirect to flash-messages.php which already
  emits role="alert"/role="status" — no additional JS announcement needed

2026-04-06 15:33:08 +02:00

4.9 KiB

Raw Blame History

TODO

Pending tasks have been split into topic files under todo/:

File	Topic
todo/01-css-semantic-refactor.md	CSS class audit, semantic HTML (public + admin), inline style extraction, favicon
todo/02-php-components.md	Form field partials, shared UI partials, controller extraction, backend maintenance
todo/03-system-cache.md	`system_cache` table, `SystemCache` class, `system.php` refactor
todo/04-accessibility.md	WCAG 2.1 AA - remaining failures grouped by success criterion

Recently completed (this session)

admin.css - added [aria-current="page"] rule for admin nav links (border-bottom: 2px solid currentColor; padding-bottom: 1px) fixing WCAG 1.4.1 (active nav link had no non-colour indicator)
admin.css - fixed undefined --admin-purple variable in pagination hover; replaced with --accent-primary (same #9557b5 value)
todo/01-css-semantic-refactor.md - audited all CSS/HTML refactor tasks; marked ~15 items as already-done (.admin-main, .admin-page-title, .admin-form-row, .admin-label, .admin-input/select/textarea, .admin-table, .admin-fieldset, tfe.css class replacements, search.css selector, login.php/edit.php inline styles, admin-alert replacement, form partial hints)
todo/04-accessibility.md - marked WCAG 1.4.1 admin nav and --admin-purple audit items as completed
admin/index.php - server-side pagination (25/page); Database::getThesesListCount() added; getThesesList() extended with $limit/$offset; access_type JOIN added to query (was missing); result-count meta line added; .pagination-wrap + .pagination-btn + .pagination-info styles added to admin.css
checkbox-list.php - replaced <div class="admin-checkbox-list"> with <fieldset class="admin-checkbox-group"><legend class="sr-only">...</legend><ul> (WCAG 1.3.1 fix)
admin.css - replaced .admin-checkbox-list with .admin-body fieldset.admin-checkbox-group > ul semantic selectors; added span.admin-row-label as visible label column counterpart
login.php - wrapped content in <main id="main-content"> landmark
account.php - <div class="admin-account-status"> → <dl>; __row divs kept; __label spans → <dt>; admin-danger-zone__description div → <p>
index.php - maintenance bar <div> → <aside role="status" aria-label="Statut du site">
add.php / edit.php - autocomplete="name" on author field, autocomplete="email" on contact field
tags.php - all inline style= attributes removed; sizing/spacing moved to CSS (.admin-input--inline, .admin-select--inline, .admin-inline-form + .admin-inline-form, .admin-tags-count)
Marked already-done items in todo files: stats <dl>, thanks.php <section>, scope="col" on both tables, tfe.php inline styles, role="alert" on flash messages
admin-submit-wrap → admin-form-footer rename: updated all 6 admin templates (add.php, edit.php, login.php, account.php, import.php, pages-edit.php) and all 8 CSS selectors in admin.css (.admin-form > div:not(...) exclusion guards, .admin-login-box overrides). Closes todo/01-css-semantic-refactor.md submit-wrap task.
Marked status-badge.php partial and WCAG 1.3.1 status-badge items as already-done in todo/02-php-components.md and todo/04-accessibility.md (partial + CSS were fully implemented; TODO had not been updated)
public/index.php — WCAG 2.4.4: home page cards now append <span class="sr-only">, YEAR</span> to each card’s <p> link text so screen readers get unique link names when two theses share the same title
todo/04-accessibility.md — WCAG 2.4.3: marked back-link focus-order item as already done (tfe-back-link is already the first DOM element in .tfe-left, before <h1>)
jury-fieldset.php — WCAG 3.3.2: replaced bare <label>Lecteur·ices :</label> with <fieldset class="admin-jury-lecteurs"><legend>Lecteur·ices</legend> so the lecteur group has a proper programmatic label
jury-fieldset.php — WCAG 4.1.2: all "Externe" checkboxes (promoteur + each lecteur row, static + dynamically added via JS) now carry aria-label="[Role] — externe" providing group context without visible redundancy
jury-fieldset.php — WCAG 2.1.1: jury remove buttons verified to have descriptive aria-label="Supprimer le lecteur·ice N" on all rows (static + dynamic)
admin.css — added .admin-body fieldset fieldset.admin-jury-lecteurs rule: strips border/background on the nested lecteur fieldset so it renders as a visual sub-group, not a double-bordered card
todo/04-accessibility.md — WCAG 1.4.4 + 1.4.12 audited and marked done: all font-sizes are rem; no overflow:hidden on essential text content

4.9 KiB Raw Blame History Unescape Escape

TODO

Recently completed (this session)

4.9 KiB

Raw Blame History